Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link in unmanaged security groups #370

Closed
eliecharra opened this issue Mar 26, 2021 · 3 comments
Closed

Fix broken link in unmanaged security groups #370

eliecharra opened this issue Mar 26, 2021 · 3 comments
Assignees
@sjourdan
Labels
kind/bug Something isn't working
Milestone
v0.7.1

Comments

@eliecharra
Copy link
Contributor

Description
Fix broken link there https://github.com/cloudskiff/driftctl/blob/main/pkg/analyser/analyzer.go#L22 and point it to the documentation website.
@eliecharra eliecharra added the kind/bug Something isn't working label Mar 26, 2021
@eliecharra eliecharra added this to the v0.7.1 milestone Mar 26, 2021
@sundowndev sundowndev self-assigned this Mar 26, 2021
This was referenced Mar 26, 2021
Closed
Merged
@sundowndev sundowndev assigned sjourdan and unassigned sundowndev Apr 7, 2021
@sjourdan
Copy link
Contributor

LGTM

Found 9 resource(s)
 - 0% coverage
 - 0 covered by IaC
 - 9 not covered by IaC
 - 0 missing on cloud provider
 - 0/0 changed outside of IaC
You have unmanaged security group rules that could be false positives, find out more at https://docs.driftctl.com/0.7.0/limitations#terraform-resources

@eliecharra
Copy link
Contributor Author

Maybe we need to change this link to point to https://docs.driftctl.com/limitations for and always up-to-date documentation. driftctl is gonna evolve and this link will be outdated

@sjourdan sjourdan mentioned this issue Apr 13, 2021
Closed
@sjourdan
Copy link
Contributor

you're exactly right! opened #426 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjourdan sjourdan

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
v0.7.1
Development

No branches or pull requests
3 participants
@sjourdan @eliecharra @sundowndev