Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analyser): link to docs about limitations #377

Closed
wants to merge 15 commits into from
Closed

Conversation

sundowndev
Copy link
Contributor

@sundowndev sundowndev commented Mar 26, 2021

Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break yes
πŸ”— Related issues #370
❓ Documentation no

Description

Fix a broken link in an alert related to security groups.

@sundowndev sundowndev requested a review from a team as a code owner March 26, 2021 14:57
@sundowndev sundowndev added the kind/bug Something isn't working label Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #377 (99b83af) into main (e238772) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   69.48%   69.48%           
=======================================
  Files         281      281           
  Lines        6024     6024           
=======================================
  Hits         4186     4186           
  Misses       1486     1486           
  Partials      352      352           
Impacted Files Coverage Ξ”
pkg/analyser/analyzer.go 92.10% <0.00%> (ΓΈ)

@eliecharra eliecharra changed the base branch from main to v0.7 March 26, 2021 15:19
Copy link
Contributor

@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one need to be rebased on v0.7 branch instead of main

@sundowndev sundowndev closed this Mar 26, 2021
@sundowndev sundowndev deleted the fix/docsURL branch March 26, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants