Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Better error messages for AWS auth #1557

Merged
merged 1 commit into from
Jul 6, 2022
Merged

fix: Better error messages for AWS auth #1557

merged 1 commit into from
Jul 6, 2022

Conversation

eliecharra
Copy link
Contributor

@eliecharra eliecharra commented Jul 5, 2022 •
edited
Loading

Q A
🐛 Bug fix? yes and no 😅
🚀 New feature? yes and no 😅
⚠ Deprecations? no
❌ BC Break no
🔗 Related issues CFG-2002
❓ Documentation no

Description

I disabled cred validation on the provider side, and instead I added a call to sts:GetCallerIdentity on our side to be able to handle auth failure errors properly

Before
Screenshot from 2022-07-05 12-00-38

After
Screenshot from 2022-07-05 11-59-26

@eliecharra eliecharra requested a review from a team as a code owner July 5, 2022 09:57
@eliecharra eliecharra requested review from muratcelep and wbeuil and removed request for a team and muratcelep July 5, 2022 09:57
@eliecharra eliecharra added the kind/enhancement New feature or improvement label Jul 5, 2022
wbeuil
wbeuil approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this is the only/best way to validate AWS creds even for CLI calls

aws sts get-caller-identity

@eliecharra
Copy link
Contributor Author

Thanks a lot @wbeuil 🙏🏻

@eliecharra eliecharra merged commit 8dab805 into main Jul 6, 2022
@eliecharra eliecharra deleted the fix/better_aws_err_message branch July 6, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moadibfr moadibfr moadibfr approved these changes

@wbeuil wbeuil wbeuil approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliecharra @moadibfr @wbeuil