Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cty.value to compute diff #391

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Use cty.value to compute diff #391

merged 1 commit into from
Apr 26, 2021

Conversation

moadibfr
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break yes
πŸ”— Related issues #347
❓ Documentation yes

Description

Use cty.value to compute diff

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #391 (7ff002b) into main (3a470bb) will decrease coverage by 2.17%.
The diff coverage is 45.89%.

❗ Current head 7ff002b differs from pull request most recent head 80687e5. Consider uploading reports for the commit 80687e5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
- Coverage   70.73%   68.55%   -2.18%     
==========================================
  Files         284      285       +1     
  Lines        6396     6700     +304     
==========================================
+ Hits         4524     4593      +69     
- Misses       1504     1702     +198     
- Partials      368      405      +37     
Impacted Files Coverage Ξ”
pkg/analyser/analysis.go 96.96% <ΓΈ> (-0.44%) ⬇️
pkg/cmd/scan.go 81.53% <0.00%> (-0.77%) ⬇️
pkg/remote/aws/init.go 0.00% <0.00%> (ΓΈ)
pkg/remote/github/init.go 0.00% <0.00%> (ΓΈ)
pkg/remote/remote.go 36.36% <0.00%> (ΓΈ)
pkg/resource/aws/aws_ami.go 33.33% <0.00%> (-33.34%) ⬇️
pkg/resource/aws/aws_cloudfront_distribution.go 30.00% <0.00%> (-36.67%) ⬇️
pkg/resource/aws/aws_db_instance.go 18.18% <0.00%> (-48.49%) ⬇️
pkg/resource/aws/aws_db_subnet_group.go 33.33% <0.00%> (-33.34%) ⬇️
pkg/resource/aws/aws_default_route_table.go 66.66% <ΓΈ> (ΓΈ)
... and 79 more

@moadibfr moadibfr force-pushed the new-archi/diff branch 3 times, most recently from 69bfb05 to 15e8699 Compare April 6, 2021 15:55
@moadibfr moadibfr force-pushed the new-archi/diff branch 5 times, most recently from b58ebc0 to 8f8f4a5 Compare April 12, 2021 16:50
@eliecharra eliecharra added this to the v0.9.0 milestone Apr 16, 2021
@wbeuil wbeuil force-pushed the new-archi/diff branch 15 times, most recently from d6f2ae4 to 60e5d02 Compare April 23, 2021 15:04
@eliecharra eliecharra marked this pull request as ready for review April 26, 2021 08:43
@eliecharra eliecharra requested a review from a team as a code owner April 26, 2021 08:43
@eliecharra eliecharra merged commit 44d1a8e into main Apr 26, 2021
@eliecharra eliecharra deleted the new-archi/diff branch April 26, 2021 12:50
Copy link
Contributor Author

@moadibfr moadibfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@sundowndev sundowndev added the kind/maintenance Refactoring or changes to the workspace label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants