Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'make deps' steps in CI #393

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Add missing 'make deps' steps in CI #393

merged 2 commits into from
Mar 30, 2021

Conversation

sundowndev
Copy link
Contributor

Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #...
❓ Documentation no

Description

Following 3bf8fe6, the CI was failing because Go dependencies were missing.

@sundowndev sundowndev added the kind/maintenance Refactoring or changes to the workspace label Mar 30, 2021
@sundowndev sundowndev requested a review from a team as a code owner March 30, 2021 15:33
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #393 (172e51f) into main (3bf8fe6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   69.19%   69.19%           
=======================================
  Files         281      281           
  Lines        6149     6149           
=======================================
  Hits         4255     4255           
  Misses       1542     1542           
  Partials      352      352           

Copy link
Contributor

@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sundowndev πŸ™πŸ»

@eliecharra eliecharra merged commit 6f39d5c into main Mar 30, 2021
@eliecharra eliecharra deleted the fix/ciDeps branch March 30, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants