Enforce one occurrence of filter flag #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #449 +/- ##
=======================================
Coverage 69.72% 69.72%
=======================================
Files 286 286
Lines 6593 6593
=======================================
Hits 4597 4597
Misses 1625 1625
Partials 371 371
|
sundowndev
force-pushed
the
fix/filterFlagRepeat
branch
from
0a6c479
to
9bfdce9
Compare
wbeuil
approved these changes
Apr 20, 2021
lotoussa
approved these changes
Apr 26, 2021
This was referenced Apr 28, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We still have to decide if we really want to fix this issue on our side, or in the pflag project, which already has an issue opened about this (spf13/pflag#72).