-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix docker pull issues #511
Conversation
When debugging issues within our Windows CI, I've noticed that `shescape` has a couple of bug fixes related to Windows. Although it turned out that `shescape` is not the issue here, I'm keeping that update in just for good measure.
So far, we've only handled errors when pulling with the Docker CLI. With the Docker CLI, we've "translated" errors to make them more helpful. The Windows tests have now started to fail because of a broken Docker installation, as we then fell back to the `snyk-docker-pull` library, which didn't have that error translation. This commit fixes that, and applies that error handling to both the CLI errors as well as errors from snyk-docker-pull.
Many may `[object Object]`s in our debug messages which are not helpful.
Expected release notes (by @tommyknows) features: fixes: others (will not be included in Semantic-Release notes):
|
As we noticed that the tests failed because of a broken Docker installation, we've decided to duplicate the job and run one job with a working, and one with a broken Docker CLI. This should give us some guarantee that these environments and the respective pull libraries behave the same.
132fbd5
to
21d7666
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
chore: update shescape
When debugging issues within our Windows CI, I've noticed that
shescape
has a couple of bug fixes related to Windows. Although itturned out that
shescape
is not the issue here, I'm keeping thatupdate in just for good measure.
fix: error handling when pulling images with pull library
So far, we've only handled errors when pulling with the Docker CLI. With
the Docker CLI, we've "translated" errors to make them more helpful.
The Windows tests have now started to fail because of a broken Docker
installation, as we then fell back to the
snyk-docker-pull
library,which didn't have that error translation.
This commit fixes that, and applies that error handling to both the CLI
errors as well as errors from snyk-docker-pull.
fix: error messages in debugs
Many may
[object Object]
s in our debug messages which are not helpful.chore: windows docker tests
As we noticed that the tests failed because of a broken Docker
installation, we've decided to duplicate the job and run one job with a
working, and one with a broken Docker CLI.
This should give us some guarantee that these environments and the
respective pull libraries behave the same.
chore: ensure Docker in CI to work