fix: always finish progress in autofixing #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cat2608
reviewed
Apr 2, 2024
Comment on lines
200
to
203
| p.ReportWithMessage(int(math.Max(tries, 99)), "Polling for fix...") | ||
| fix, complete := pollFunc() | ||
| if !complete { | ||
| tries++ |
There was a problem hiding this comment.
Is this logic to set a ceiling to the max number of retries?
There was a problem hiding this comment.
Nope, it's just to not report more than a 100% (timeout is currently set to 120, and didn't want to implement a complicated logic with rounding to integers afterwards). But I should use Min, not Max. Oops.
…tofix-fails' into fix/finish-progress-also-when-autofix-fails
cat2608
reviewed
Apr 2, 2024
Comment on lines
+200
to
+203
| p.ReportWithMessage(int(math.Min(tries, 99)), "Polling for fix...") | ||
| fix, complete := pollFunc() | ||
| if !complete { | ||
| tries++ |
There was a problem hiding this comment.
I think this is going it be showing 99 until tries passes 99, right? We are not aiming to show a progress I understand
There was a problem hiding this comment.
Now, it's gonna show a progress up to the 99s limit - with Max it was only showing 99...
cat2608
approved these changes
Apr 2, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
🚨After having merged, please update the CLI go.mod to pull in latest language server.
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!