chore: disable analytics & sentry when fedramp [HEAD-677] #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
Snyk.VisualStudio.Extension.Shared/Settings/SnykGeneralOptionsDialogPage.cs
Outdated
Show resolved
Hide resolved
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
bastiandoetsch
had a problem deploying
to
snyk-msbuild-envs
GitHub Actions
Error
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
PeterSchafer
reviewed
Sep 1, 2023
Snyk.VisualStudio.Extension.Shared/Settings/SnykGeneralOptionsDialogPage.cs
Outdated
Show resolved
Hide resolved
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
PeterSchafer
approved these changes
Sep 1, 2023
asaf92
approved these changes
Sep 4, 2023
| @@ -14,6 +14,8 @@ public interface ISnykOptions | |||
| /// </summary> | |||
| AuthenticationToken ApiToken { get; } | |||
|
|
|||
| bool IsFedramp(); | |||
There was a problem hiding this comment.
Usually when you have FooType GetFoo(), it's idiomatic to use a getter only auto-property, so FooType Foo { get; }
Comment on lines
+92
to
+102
| public bool IsFedramp() | ||
| { | ||
| var endpoint = this.customEndpoint; | ||
| if (endpoint.IsNullOrEmpty()) | ||
| { | ||
| return false; | ||
| } | ||
|
|
||
| var endpointUri = new Uri(endpoint); | ||
| return endpointUri.Host.ToLower().EndsWith("snykgov.io"); | ||
| } |
There was a problem hiding this comment.
(Suggestion)
You can also do something like this:
Suggested change
| public bool IsFedramp() | |
| { | |
| var endpoint = this.customEndpoint; | |
| if (endpoint.IsNullOrEmpty()) | |
| { | |
| return false; | |
| } | |
| var endpointUri = new Uri(endpoint); | |
| return endpointUri.Host.ToLower().EndsWith("snykgov.io"); | |
| } | |
| public bool IsFedramp() => > Uri.TryCreate(this.customEndpoint, UriKind.Absolute, out var uri) && | |
| uri.Host.ToLower().EndsWith("snykgov.io"); |
It's shorter and handles any error in the URI parsing (like invalid format). I recently added code to the CustomEndpoint setter to avoid invalid URIs, but it's better to be safe anyway.
CALISOULB
approved these changes
Sep 7, 2023
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
bastiandoetsch
deleted the
chore/HEAD-677_disable-analytics-and-sentry-when-fedramp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!