Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CLI release channels #300

Merged
merged 18 commits into from
Sep 17, 2024
Merged

feat: CLI release channels #300

merged 18 commits into from
Sep 17, 2024

Conversation

ShawkyZ
Copy link
Contributor

@ShawkyZ ShawkyZ commented Sep 13, 2024 •
edited
Loading

Description

  • Added CLI Release Channels
  • Added option to change CLI download URL
  • Bug fixes in CLI downloader
  • Attempt to check for Trust if a new folder is opened before starting LS
  • Change settings persistence to only use UserStorageSettingsService
  • Preserve Tree State if an Item is selected

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@ShawkyZ ShawkyZ requested a review from a team as a code owner September 13, 2024 10:53
@ShawkyZ ShawkyZ changed the title feat: wip cli downloads feat: CLI release channels Sep 13, 2024
@ShawkyZ ShawkyZ marked this pull request as draft September 13, 2024 10:58
ShawkyZ
ShawkyZ commented Sep 13, 2024
View reviewed changes
Snyk.VisualStudio.Extension.2022/Download/SnykCliDownloader.cs
@@ -16,26 +17,26 @@ namespace Snyk.VisualStudio.Extension.Download
/// </summary>
public class SnykCliDownloader
{
private const string BaseUrl = "https://downloads.snyk.io";
public const string DefaultBaseDownloadUrl = "https://downloads.snyk.io";
public const string DefaultReleaseChannel = "preview";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will switch to default stable before GA

ShawkyZ
ShawkyZ commented Sep 16, 2024
View reviewed changes
Snyk.VisualStudio.Extension.2022/Settings/SnykUserStorageSettingsService.cs Outdated
{
var settings = this.LoadSettings();
settings.Organization = value;
this.settingsLoader.Save(settings);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to only save when dialog is closed

acke
acke approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@acke acke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShawkyZ ShawkyZ merged commit 770f579 into main Sep 17, 2024
16 checks passed
@ShawkyZ ShawkyZ deleted the feat/cli-release-channels branch September 17, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acke acke acke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShawkyZ @acke