Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always finish progress when auto-fixing in language server #5145

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

bastiandoetsch
Copy link
Contributor

@bastiandoetsch bastiandoetsch commented Apr 2, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

This PR pulls in the latest language server. This ensures, progresses are ended even if errors occur. Also, behind a feature flag, some changes to prepare for global ignores are included, as they came before this commit & PR.

⚠️ This also changes the circleci workflow to use the configured go binary instead of the circleci/go image with a potentially random go version.

Risk: LOW

Where should the reviewer start?

snyk/snyk-ls@9d7d19c
snyk/snyk-ls#478

How should this be manually tested?

  • compile CLI
  • direct your IDE to the compiled CLI and disable automatic management of dependencies
  • use the IDE to scan with snyk

Any background context you want to provide?

In case of DeepCode AI fix failing, the progress.End() command was never called.

What are the relevant tickets?

IDE-134

Screenshots

Additional questions

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner April 2, 2024 14:48
@bastiandoetsch bastiandoetsch enabled auto-merge (squash) April 2, 2024 14:48
@bastiandoetsch bastiandoetsch force-pushed the fix/IDE-134_fix-progress-in-autofix branch from 5a605ec to 0fe499e Compare April 2, 2024 15:06
@bastiandoetsch bastiandoetsch force-pushed the fix/IDE-134_fix-progress-in-autofix branch 2 times, most recently from 21c1ac9 to e9ef4e0 Compare April 3, 2024 09:58
@bastiandoetsch bastiandoetsch enabled auto-merge (squash) April 3, 2024 09:58
@bastiandoetsch bastiandoetsch force-pushed the fix/IDE-134_fix-progress-in-autofix branch from e9ef4e0 to 8433115 Compare April 3, 2024 09:59
@bastiandoetsch bastiandoetsch force-pushed the fix/IDE-134_fix-progress-in-autofix branch from 8433115 to 632dd7b Compare April 3, 2024 11:16
@bastiandoetsch bastiandoetsch merged commit f645bbe into main Apr 3, 2024
11 of 14 checks passed
@bastiandoetsch bastiandoetsch deleted the fix/IDE-134_fix-progress-in-autofix branch April 3, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants