Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link in README.md #484

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Fix broken link in README.md #484

merged 3 commits into from
Mar 5, 2024

Conversation

unixorn
Copy link
Contributor

@unixorn unixorn commented Mar 1, 2024

Closes #483

@unixorn
Fix broken link in README.md
b7887b2 
Closes so-fancy#483

Signed-off-by: Joe Block <jpb@unixorn.net>
@scottchiefbaker
Copy link
Contributor

The link should target /blob/next/pro-tips.md instead of a full path. Otherwise it looks fine. Update the target and I'll land this.

@unixorn
Updated link per feedback
21a6de2 
Signed-off-by: Joe Block <jpb@unixorn.net>
@unixorn
Copy link
Contributor Author

unixorn commented Mar 3, 2024

Done!

@scottchiefbaker
Copy link
Contributor

Sorry I wasn't clear... You should drop the http://... part of the link. That will make the link work on alternate branches and not always link to main. Just linking to /blob/next/pro-tips.md#zsh-plugin-suppport-for-diff-so-fancy should be sufficient.

@unixorn
Update link per feedback
80fde05 
Remove the `http://...` portion of the link

Signed-off-by: Joe Block <jpb@unixorn.net>
@unixorn
Copy link
Contributor Author

unixorn commented Mar 5, 2024

No problem, done.

@scottchiefbaker scottchiefbaker merged commit b58488a into so-fancy:next Mar 5, 2024
2 checks passed
@unixorn unixorn deleted the fix-483 branch March 5, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken link in ZSH install instructions
2 participants
@unixorn @scottchiefbaker