Added custom container support from @tpaksu branch and control positioning support from @lucadegasperi branch. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this control does not allow to set its position inside the map frame. This simple change allows for this behavior.
jreviews
reviewed
Oct 30, 2019
dd
pushed a commit
to dd/vue-mapbox-geocoder
that referenced
this pull request
May 20, 2020
woshikie
added a commit
to woshikie/vue-mapbox-geocoder
that referenced
this pull request
Oct 22, 2020
* chore: add position prop * fix: No mapboxgl detected in options. Map markers are disabled. Please set options.mapboxgl. * update package * fix: mapboxGl as prop not mapboxgl * chore: update build * chore: update package.json * chore: update mapboxgl prop * chore: update multi-query string * chore: update build to support multiquery * fix: typo error * chore: update build * feat: add marker as props * fix: update build * fix: update debouce issue caused by vue component * fix: update build * chore: remove the `_updateInput` method causing debounce issue * chore: update build * fix query method * update passed props to MapboxGeocoder * fix: remove dist build * feat(bot): setup dependabot 🤖 * feat(bot): setup semantic pr 🤖 * chore: minor housekeeping 🧹 * feat(lint): add commitlint & husky 🏗 * chore(housekeeping): gitignore, prettier & babel configs 🥳 * refactor: remove public directory 📂 * feat(ci): add github action 🏗 * build(rollup): add rollup configs 👨🔧 * chore: add LICENSE 📓 * refactor(source): refactor GeoCoderCtrl & remove vue config file 💅 * docs: update README 🥳 * feat: add jsconfig for better intellisense 🔌 * refactor: add package.json & lockfile 🚀 * chore: update lockfile to include ship.js * chore: release v0.1.0 (soal#5) * chore(deps): update lockfile with correct scope * chore: release v0.1.1 (soal#7) * chore(deps-dev): bump rollup from 2.10.4 to 2.10.5 Bumps [rollup](https://github.com/rollup/rollup) from 2.10.4 to 2.10.5. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.10.4...v2.10.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * fix: stop squishing results after updating input - ref: soal#14 * fix: typo issue * chore: update docs - ref soal#10 * fix: no mapboxgl detected issue - ref soal#8 * feat: add geocoder based on custom container_id * docs: update example * feat: add badges * chore: update alignment * chore: release v0.2.0 (soal#15) * Add `prepare` script It is needed for the `npm i git+https://github.com/dd/vue-mapbox-geocoder.git` command to build the package Co-authored-by: Vinayak Kulkarni <inbox.vinayak@gmail.com> Co-authored-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com> Co-authored-by: dd <dd@manin.space> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Alexander Kaidalov <twildor@gmail.com>
|
Closing this as it's been open for 2 years, and I don't want my PR list crowded :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull, the plugin will have the option to place the input in another container element in the page or a different position on the owner map.
Usage:
container: the id of the container element to put the input in.
position: the position within the map boundaries,
Note: Can't be used together with container option. Container will override position.