-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gemma.cpp bindings / llm-chain-gemma. #281
Conversation
Hi, can you run the CI tasks again? I think I've addressed them (although I'm not sure if it fixes Windows build as I don't have windows environment) |
Thanks for that :) seems the CI itself passe |
Other than windows |
Sigh, sorry about that. I made one more change, I hope it fixes the windows build... |
Still some weird issue with windows @jmuk |
Looks like an error on compiling C++ code, possibly due to a macro defined in a standard Windows header file? (cf. https://stackoverflow.com/questions/5004858/why-is-stdmin-failing-when-windows-h-is-included). I checked gemma.cpp repository but seemingly their CI includes windows and it looks fine. |
I checked gemma.cpp and recent version has However the gemma.cpp interface has changed very significantly. I rebuilt bindings.cc and others to catch up with that and confirmed it's built and works successfully on my local macbook. Sorry for the troubles, but please run the CI checks again! |
Sigh, I just found that gemma.cpp does not support MSBuild / MSVC, it only supports clang-cl for now. I gave up on Windows build; with the new patch, it should pass the build on Windows and CI should pass, but on Windows it will raise Please run the CI again! |
The CI seems retried yesterday but that was on an older revision? Could someone run the CI on the latest one 4293284 |
All good. Seems like it is ready to merge. Let me know you want me to go ahead and package it |
Yay! Please go ahead anytime you can. |
No description provided.