Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gemma.cpp bindings / llm-chain-gemma. #281

Merged
merged 11 commits into from
Mar 21, 2024
Merged

Add gemma.cpp bindings / llm-chain-gemma. #281

merged 11 commits into from
Mar 21, 2024

Conversation

jmuk
Copy link
Contributor

@jmuk jmuk commented Mar 8, 2024

No description provided.

@jmuk
Copy link
Contributor Author

jmuk commented Mar 13, 2024

Hi, can you run the CI tasks again? I think I've addressed them (although I'm not sure if it fixes Windows build as I don't have windows environment)

@williamhogman
Copy link
Contributor

Thanks for that :) seems the CI itself passe

@williamhogman
Copy link
Contributor

Other than windows

@jmuk
Copy link
Contributor Author

jmuk commented Mar 14, 2024

Sigh, sorry about that. I made one more change, I hope it fixes the windows build...

@williamhogman
Copy link
Contributor

Still some weird issue with windows @jmuk

@jmuk
Copy link
Contributor Author

jmuk commented Mar 14, 2024

Looks like an error on compiling C++ code, possibly due to a macro defined in a standard Windows header file? (cf. https://stackoverflow.com/questions/5004858/why-is-stdmin-failing-when-windows-h-is-included). I checked gemma.cpp repository but seemingly their CI includes windows and it looks fine.
I'll check how it's resolved there and ports their resolution here -- which is (I hope) simply updating gemme.cpp version referred in the .gitmodule file.

@jmuk
Copy link
Contributor Author

jmuk commented Mar 15, 2024

I checked gemma.cpp and recent version has NOMINMAX macro for windows, which should resolve the build issue. I updated the version so I think it won't get trapped by that error.

However the gemma.cpp interface has changed very significantly. I rebuilt bindings.cc and others to catch up with that and confirmed it's built and works successfully on my local macbook. Sorry for the troubles, but please run the CI checks again!

@jmuk
Copy link
Contributor Author

jmuk commented Mar 19, 2024

Sigh, I just found that gemma.cpp does not support MSBuild / MSVC, it only supports clang-cl for now. I gave up on Windows build; with the new patch, it should pass the build on Windows and CI should pass, but on Windows it will raise ExecutorCreationError on Windows.

Please run the CI again!

@jmuk
Copy link
Contributor Author

jmuk commented Mar 20, 2024

The CI seems retried yesterday but that was on an older revision? Could someone run the CI on the latest one 4293284

@williamhogman
Copy link
Contributor

All good. Seems like it is ready to merge. Let me know you want me to go ahead and package it

@jmuk
Copy link
Contributor Author

jmuk commented Mar 21, 2024

Yay! Please go ahead anytime you can.

@Juzov Juzov merged commit 5e15391 into sobelio:main Mar 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants