Dev #13
Open
Dev #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cumulative bandwidth parameter
…lace). Recorded bandwidth info is correct, but some modules are still being entirely skipped
… use dynamic type, and made sure skipping logic works, nothing is done for module count skipping
Feature lines parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we did
We added the ability to extract the bandwidth of individual modules as well as the total. We also enabled handling mixed format log files, as some of the log files contain a mix of JSON and NGINX
How to review (using worldpossible_test_dev resource group)
Delete the contents of the processedjson and webserverlog containers and the contents of the Cosmos DB, upload a new log file to the webserverlog, and verify that it creates the correct JSON files and has the correct output in Cosmos DB. It can also be viewed in "World Possible Dev.pbix"
Known Issues
As before, records from the same second are skipped (except for the bandwidth).