Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: add a maximum length for the URL
The regular expression used to parse the URL provided by the user has a time complexity of O(n^2), hence the length limitation. Please note that this does not seem realistically exploitable, as an attacker would have to be able to provide a malicious URL to the user and inject it in the Engine.IO client. We could also have: - modified the regex, but there are a lot of edge cases and the current test coverage is probably not sufficient - use the built-in URL object, but we would have to add a polyfill for old platforms like IE Thanks to Young-jin Hwang from the Soonchunhyang University for the responsible disclosure.
- Loading branch information