Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve packet type #630

Closed

Conversation

naseemkullah
Copy link

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation (formatted readme)
  • a code change that improves performance
  • other

Other information (e.g. related issues)

improve packet type

@naseemkullah
Copy link
Author

cc @darrachequesne

export interface Packet {
type: PacketType;
options: { compress: boolean };
data?: any;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darrachequesne I noticed within the engine codebase string is sufficient, but IRL i also got array type, can this really be anything?

@naseemkullah
Copy link
Author

CI failing with:

npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/uNetworking/uWebSockets.js.git
npm ERR! 
npm ERR! Warning: Permanently added the RSA host key for IP address '140.82.112.4' to the list of known hosts.
npm ERR! git@github.com: Permission denied (publickey).
npm ERR! fatal: Could not read from remote repository.
npm ERR! 
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.
npm ERR! 
npm ERR! exited with error code: 128

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2021-11-25T21_31_18_011Z-debug.log
Error: Process completed with exit code 1.

darrachequesne added a commit to socketio/engine.io-parser that referenced this pull request Jan 17, 2022
darrachequesne added a commit that referenced this pull request Jan 18, 2022
@darrachequesne
Copy link
Member

@naseemkullah your PR has been merged in e122e4b

Thanks a lot for your work on this 👍

@naseemkullah naseemkullah deleted the improve-packet-type branch January 18, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants