-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve packet type #630
Closed
Closed
Improve packet type #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naseemkullah
force-pushed
the
improve-packet-type
branch
from
November 25, 2021 20:20
7d9ca52
to
0c3e8a5
Compare
naseemkullah
force-pushed
the
improve-packet-type
branch
from
November 25, 2021 21:10
0c3e8a5
to
4d07892
Compare
naseemkullah
commented
Nov 25, 2021
export interface Packet { | ||
type: PacketType; | ||
options: { compress: boolean }; | ||
data?: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darrachequesne I noticed within the engine codebase string
is sufficient, but IRL i also got array type, can this really be anything?
CI failing with:
|
darrachequesne
added a commit
to socketio/engine.io-parser
that referenced
this pull request
Jan 17, 2022
@naseemkullah your PR has been merged in e122e4b Thanks a lot for your work on this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Other information (e.g. related issues)
improve packet type