Skip to content

Commit

Permalink
refactor: remove the 'connecting' event
Browse files Browse the repository at this point in the history
This event was added in 4195680

But it does not convey the information that the Socket is actually
sending a CONNECT packet to the server. It should maybe be moved to the
Socket#onopen() method, but let's remove it for now as it is not
documented anywhere.
  • Loading branch information
darrachequesne committed Oct 12, 2020
1 parent 6494f61 commit b60e909
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions lib/socket.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ export class Socket extends Emitter {
this.subEvents();
if (!this.io.reconnecting) this.io.open(); // ensure open
if ("open" === this.io.readyState) this.onopen();
super.emit("connecting");
return this;
}

Expand All @@ -101,7 +100,6 @@ export class Socket extends Emitter {
this.subEvents();
if (!this.io.reconnecting) this.io.open(); // ensure open
if ("open" === this.io.readyState) this.onopen();
super.emit("connecting");
return this;
}

Expand Down

0 comments on commit b60e909

Please sign in to comment.