[feat] Move binary detection to the parser (#66)

socketio · Apr 24, 2017 · f44256c · f44256c
1 parent 817adca
commit f44256c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -5,6 +5,7 @@
 
 var debug = require('debug')('socket.io-parser');
 var Emitter = require('component-emitter');
+var hasBin = require('has-binary2');
 var binary = require('./binary');
 var isBuf = require('./is-buffer');
 
@@ -123,6 +124,10 @@ function Encoder() {}
  */
 
 Encoder.prototype.encode = function(obj, callback){
+  if ((obj.type === exports.EVENT || obj.type === exports.ACK) && hasBin(obj.data)) {
+    obj.type = obj.type === exports.EVENT ? exports.BINARY_EVENT : exports.BINARY_ACK;
+  }
+
   debug('encoding packet %j', obj);
 
   if (exports.BINARY_EVENT === obj.type || exports.BINARY_ACK === obj.type) {

diff --git a/package.json b/package.json
@@ -14,6 +14,7 @@
   "dependencies": {
     "debug": "2.3.3",
     "component-emitter": "1.2.1",
+    "has-binary2": "1.0.1",
     "isarray": "2.0.1"
   },
   "devDependencies": {