-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework file structure & license header. #89
Conversation
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Good compatibility workout!
@olleolleolle I hope it's sufficient, this gem has a lot of downloads. |
Excuse me, but why all these hardcoded warnings' noise in the logs now? |
Because you updated the gem and we are emitting warnings for files that will eventually be removed because they are clobbering global namespace/paths. |
I understand the primary reason, but then there was #91, where all these constants where deprecated via |
The files and the constants they define are two separate issues with separate warnings. It sounds like you are suggesting to remove the explicit warnings from the files. It's probably better we just fix the dependencies. If you don't want to deal with the warnings, stay with the old versions? |
Tidy up the file structure including
require_relative
where it makes sense.Types of Changes