Windows / MinGW test failure - fix spec_helper.rb #157

MSP-Greg · 2017-06-27T00:09:51Z

See 'Test failures on Windows (MinGW)' #156

tarcieri · 2017-06-27T00:13:22Z

Well nice, down to 1 failure now, although it's the same one you reported in #156:

https://ci.appveyor.com/project/tarcieri/nio4r/build/2.1.15/job/7bxd7jw2gjpbh9rj#L438

MSP-Greg · 2017-06-27T00:26:49Z

I'll see if I can get to that. I have some patches for Ruby socket tests that I need to look over...

May not be tonite (I'm central). Thanks.

tarcieri · 2017-06-27T00:27:20Z

Thanks for taking a look!

MSP-Greg · 2017-06-29T01:24:58Z

@tarcieri

I've got MinGW down to --

Finished in 36.39 seconds (files took 0.6396 seconds to load)
101 examples, 0 failures, 2 pending

Changes to pipe, ssl_socket, & udp_socket, along with three deleted comment lines from selectable_examples. Hoping Travis shows the same.

Add another commit to this, another PR, etc. What would you prefer?

tarcieri · 2017-06-29T05:59:14Z

Go ahead and push onto this PR and let's take a look at the Appveyor results

tarcieri · 2017-06-29T06:00:17Z

Note there are explicitly configured directives to skip Appveyor failures here:

https://github.com/socketry/nio4r/blob/master/appveyor.yml#L11

A successful PR for this problem should remove the entire matrix block and ensure there are no Appveyor failures.

MSP-Greg · 2017-06-29T22:30:57Z

@tarcieri

Not quite there yet. I tested with the following ruby builds:

ruby 2.2.8p471 (2017-03-29) [x64-mingw32]                 stable branch
ruby 2.3.5p310 (2017-05-01) [x64-mingw32]                 stable branch

ruby 2.4.1p111 (2017-03-22 revision 58053) [x64-mingw32]  rubyinstaller-2.4.1-2-x64

ruby 2.5.0dev (2017-06-28 trunk 59198) [x64-mingw32]      Trunk

All had identical results of:

Pending: (Failures listed here are expected and do not affect your suite's status)

  1) UDPSocket behaves like an NIO selectable does not select unwritable objects
     # come up with a UDPSocket that's blocked on writing
     Failure/Error: raise TypeError, "can't convert #{io.class} into IO" unless io.is_a? IO

     TypeError:
       can't convert NilClass into IO
     Shared Example Group: "an NIO selectable" called from ./spec/nio/selectables/udp_socket_spec.rb:42
     # ./lib/nio/monitor.rb:18:in `initialize'
     # ./lib/nio/selector.rb:55:in `new'
     # ./lib/nio/selector.rb:55:in `block in register'
     # ./lib/nio/selector.rb:49:in `synchronize'
     # ./lib/nio/selector.rb:49:in `register'
     # ./spec/support/selectable_examples.rb:26:in `block (2 levels) in <top (required)>'

  2) IO.pipe behaves like an NIO selectable does not select unwritable objects
     # windows - can't test due to 'select' not showing correct status
     # ./spec/support/selectable_examples.rb:25

101 examples, 0 failures, 2 pending

For the two Travis failures, suspect it might be that spec/nio/selectables/udp_socket_spec.rb:33
should just be break, but I can't test. If you'd like, I could merge that and see how it tests.

As to the Appveyor ruby 22 failure, as you probably know, it's not building. As shown above, I installed it with 2.2.8 (built with my tools based on MSYS2/MinGW).

FYI, the builds that Appveyor is currently using were created with the original RubyInstaller system. The system was based on MSYS/MinGW tools, but did not use the tools as normally configured.

My builds, and the newer (2.4+) RubyInstaller2 builds, are based on MSYS2/MinGW. I have been using the newer set of tools for a long time. So, I'll try to look at the 22 build failure, but I may instead try to contact Appveyor about updating the ruby builds they are using...

MSP-Greg · 2017-06-29T23:28:23Z

@tarcieri

re Appveyor build matrices, a few others Ruby pysch, Ruby openssl

I wonder if nio4r would build with 22-x64 (or 23-x64)? FWIW, I believe Appveyor Ruby builds are using gcc 4.7.x. The RubyInstaller2 / MSYS2 /minGW systems are using gcc 6.3.0.

tarcieri · 2017-06-30T00:44:51Z

I don't know the difference offhand, and I'm open regarding advice about Windows toolchains, especially if we can get them properly documented in the README

MSP-Greg · 2017-06-30T01:23:18Z

Questions:

Thoughts on the travis failures?
Does anyone in the non-Windows world still use 32 bit builds / OS's?

I don't really want to try and dredge thru why ruby22 isn't building, especially since my builds work with 2.2 thru 2.5.

I'm thinking about two items:

Move Appveyor along with updating their ruby builds.
Package x64-mingw32 & x86-mingw32 builds of nio4r.

tarcieri · 2017-06-30T01:52:00Z

spec/nio/selectables/udp_socket_spec.rb

@@ -22,7 +22,17 @@
  end

  let :writable_subject do
-    pending "come up with a writable UDPSocket example"


This seems to be the main source of the Travis failures...

Can you see what the error is on the rescue? I couldn't fill up the UDP socket (or generate an error) on Windows.

I'm confused why just two of the travis build jobs failed, and both state 'Expected pending "UDPSocket Error' to fail. No error was raised."

What if the end while condition is removed, and keep some kind of rescue to make sure it can be written to. Maybe that will be better?

The problem is on Travis, your example manages to create a writable_subject, but then the subsequent tests are failing.

I'm not sure why they're failing but it's not entirely unexpected considering this was just pending before. It was likely pending because of sporadic CI failures.

It was likely pending because of sporadic CI failures.

I really hate it when that happens. Maybe add a line to output the error type and skip/pending for that (once we see what it is)?

tarcieri · 2017-06-30T01:52:48Z

#4 sounds fantastic if that's something you're interested in working on

MSP-Greg · 2017-06-30T02:33:35Z

#4 sounds fantastic if that's something you're interested in working on

Making the gem packages shouldn't take too long; I've just got to figure out how to package what I've already got. I'll jig up a repo so I can test them with the appveyor ruby versions...

MSP-Greg · 2017-06-30T04:43:58Z

Sorry about that merge. I'll get rid of it tomorrow. Note to self - never use GitHub client for PR work.

Fixed appveyor.yml, see Appveyor MSP-Greg/nio4r

tarcieri · 2017-06-30T14:06:49Z

Nice!

tarcieri · 2017-06-30T22:21:27Z

Looking great! Mind squashing these commits?

See 'Test failures on Windows (MinGW)' socketry#156 Windows / MinGW tests - update spec & examples Windows / MinGW - appveyor.yml

MSP-Greg · 2017-07-01T00:49:47Z

All green. I'll see about creating mingw specific gem packages. Then again, now that 2.2 - 2.4 are building, less of a concern.

I'll be back if anything changes re Appveyor. Maybe I can get them to start using a daily ruby trunk build.

Have a good weekend, and thanks...

tarcieri · 2017-07-04T17:33:11Z

Looks good! Thanks for contributing!

MSP-Greg force-pushed the mingw_tests_1 branch from 42e75e9 to de68776 Compare June 29, 2017 13:57

tarcieri reviewed Jun 30, 2017

View reviewed changes

MSP-Greg force-pushed the mingw_tests_1 branch from fa6c299 to 62aa409 Compare June 30, 2017 18:27

Windows / MinGW test failure - fix spec_helper.rb

f8e468c

See 'Test failures on Windows (MinGW)' socketry#156 Windows / MinGW tests - update spec & examples Windows / MinGW - appveyor.yml

MSP-Greg force-pushed the mingw_tests_1 branch from 62aa409 to f8e468c Compare June 30, 2017 22:59

tarcieri merged commit 530fd62 into socketry:master Jul 4, 2017

MSP-Greg deleted the mingw_tests_1 branch July 4, 2017 18:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows / MinGW test failure - fix spec_helper.rb #157

Windows / MinGW test failure - fix spec_helper.rb #157

MSP-Greg commented Jun 27, 2017

tarcieri commented Jun 27, 2017

MSP-Greg commented Jun 27, 2017

tarcieri commented Jun 27, 2017

MSP-Greg commented Jun 29, 2017

tarcieri commented Jun 29, 2017

tarcieri commented Jun 29, 2017

MSP-Greg commented Jun 29, 2017

MSP-Greg commented Jun 29, 2017

tarcieri commented Jun 30, 2017

MSP-Greg commented Jun 30, 2017 •

edited

Loading

tarcieri Jun 30, 2017

MSP-Greg Jun 30, 2017

tarcieri Jun 30, 2017

MSP-Greg Jun 30, 2017

tarcieri commented Jun 30, 2017

MSP-Greg commented Jun 30, 2017

MSP-Greg commented Jun 30, 2017

tarcieri commented Jun 30, 2017

tarcieri commented Jun 30, 2017

MSP-Greg commented Jul 1, 2017

tarcieri commented Jul 4, 2017

Windows / MinGW test failure - fix spec_helper.rb #157

Windows / MinGW test failure - fix spec_helper.rb #157

Conversation

MSP-Greg commented Jun 27, 2017

tarcieri commented Jun 27, 2017

MSP-Greg commented Jun 27, 2017

tarcieri commented Jun 27, 2017

MSP-Greg commented Jun 29, 2017

tarcieri commented Jun 29, 2017

tarcieri commented Jun 29, 2017

MSP-Greg commented Jun 29, 2017

MSP-Greg commented Jun 29, 2017

tarcieri commented Jun 30, 2017

MSP-Greg commented Jun 30, 2017 • edited Loading

tarcieri Jun 30, 2017

Choose a reason for hiding this comment

MSP-Greg Jun 30, 2017

Choose a reason for hiding this comment

tarcieri Jun 30, 2017

Choose a reason for hiding this comment

MSP-Greg Jun 30, 2017

Choose a reason for hiding this comment

tarcieri commented Jun 30, 2017

MSP-Greg commented Jun 30, 2017

MSP-Greg commented Jun 30, 2017

tarcieri commented Jun 30, 2017

tarcieri commented Jun 30, 2017

MSP-Greg commented Jul 1, 2017

tarcieri commented Jul 4, 2017

MSP-Greg commented Jun 30, 2017 •

edited

Loading