Skip to content

Commit

Permalink
fix(src/cli/cli.cc): make ssc build fail early when [meta] build_iden…
Browse files Browse the repository at this point in the history
…tifier is not provided
  • Loading branch information
chicoxyzzy committed Sep 15, 2023
1 parent 0729bc6 commit a419104
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/cli/cli.cc
Original file line number Diff line number Diff line change
Expand Up @@ -975,10 +975,6 @@ void runIOSSimulator (const Path& path, Map& settings) {
log("ERROR: [ios] simulator_device option is empty");
exit(1);
}
if (settings["meta_bundle_identifier"].size() == 0) {
log("ERROR: [meta] bundle_identifier option is empty");
exit(1);
}
String deviceType;
StringStream listDeviceTypesCommand;
listDeviceTypesCommand
Expand Down Expand Up @@ -2415,6 +2411,11 @@ int main (const int argc, const char* argv[]) {
// Insert the elements of runOptions into buildOptions
buildOptions.insert(buildOptions.end(), runOptions.begin(), runOptions.end());
createSubcommand("build", buildOptions, true, [&](Map optionsWithValue, std::unordered_set<String> optionsWithoutValue) -> void {
if (settings["meta_bundle_identifier"].size() == 0) {
log("ERROR: [meta] bundle_identifier option is empty");
exit(1);
}

String argvForward = "";
String targetPlatform = optionsWithValue["--platform"];
String additionalBuildArgs = "";
Expand Down

0 comments on commit a419104

Please sign in to comment.