Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use 'hasEnv' for env value checks #541

Merged
merged 2 commits into from
Aug 31, 2023
Merged

use 'hasEnv' for env value checks #541

merged 2 commits into from
Aug 31, 2023

Conversation

jwerle
Copy link
Member

@jwerle jwerle commented Aug 31, 2023

Fixes #528

@jwerle jwerle added the bug Something isn't working label Aug 31, 2023
@jwerle jwerle requested a review from bcomnes August 31, 2023 21:04
@jwerle jwerle self-assigned this Aug 31, 2023
bcomnes
bcomnes reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yes, every detail counts.

@jwerle jwerle merged commit bbd5d7f into master Aug 31, 2023
5 of 8 checks passed
@jwerle jwerle deleted the fix-528 branch August 31, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcomnes bcomnes bcomnes approved these changes

Assignees

@jwerle jwerle

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENV vars defined in socket.ini always come in as '' when undefined
2 participants
@jwerle @bcomnes