Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ssc build fail early when [meta] build_identifier is not provided #597

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Make ssc build fail early when [meta] build_identifier is not provided #597

merged 5 commits into from
Sep 18, 2023

Conversation

chicoxyzzy
Copy link
Member

@chicoxyzzy chicoxyzzy commented Sep 15, 2023 •
edited
Loading

TODO:

  • check that build_identifier is a valid string
  • check for other required fields (checks are there already)

Bonus:

  • more config docs

@chicoxyzzy chicoxyzzy self-assigned this Sep 15, 2023
jwerle
jwerle reviewed Sep 16, 2023
View reviewed changes
src/cli/cli.cc Outdated Show resolved Hide resolved
@chicoxyzzy chicoxyzzy force-pushed the fail_early branch 3 times, most recently from e091844 to 0d42af7 Compare September 18, 2023 12:38
@chicoxyzzy chicoxyzzy marked this pull request as ready for review September 18, 2023 14:09
jwerle
jwerle reviewed Sep 18, 2023
View reviewed changes
src/cli/templates.hh Outdated Show resolved Hide resolved
@chicoxyzzy chicoxyzzy merged commit 554e3d2 into master Sep 18, 2023
5 of 8 checks passed
@chicoxyzzy chicoxyzzy deleted the fail_early branch September 18, 2023 15:17
@chicoxyzzy chicoxyzzy added documentation Improvements or additions to documentation cli labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwerle jwerle jwerle approved these changes

@heapwolf heapwolf Awaiting requested review from heapwolf

Assignees

@chicoxyzzy chicoxyzzy

Labels
cli documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chicoxyzzy @jwerle