Implemented window title version number and instance+session persistent directory memory #89
Conversation
Darojax
commented
Sep 13, 2024
Darojax
commented
- App will remember the last directory used, multiple apps will remember their own directory used. (Not persistent across app restarts.)
- Added app version displaying in the window title based on value in in ReforgerServerApp.csproj
Appended by accident
|
json files appended by mistake, please ignore them. |
|
This needs to target |
| @@ -21,6 +22,9 @@ public Main() | |||
| { | |||
| InitializeComponent(); | |||
|
|
|||
| // Set the window title with the version number | |||
| this.Text = $"ReforgerServerApp - {GetAppVersion()}"; | |||
There was a problem hiding this comment.
Should be "Arma Reforger Dedicated Server Tool", There are some messagebox constants in Utils/Constants.cs, instead of having:
. . .
public static string WARN_MESSAGEBOX_TITLE_STR = "Arma Reforger Dedicated Server Tool - Warning";
public static string INFO_MESSAGEBOX_TITLE_STR = "Arma Reforger Dedicated Server Tool - Information";
. . .
we could have public static string APPLICATION_NAME = "Arma Reforger Dedicated Server Tool"; and each of the messagebox strings can be APPLICATION_NAME + blah and then you could refer to APPLICATION_NAME here to keep things consistent across the app
| /// Retrieves the application's version number. | ||
| /// </summary> | ||
| /// <returns>Formatted version string.</returns> | ||
| private string GetAppVersion() |
There was a problem hiding this comment.
Probably shouldn't be in Main, maybe this can live in FileIOManager? There's not really a good home for it at the moment
| // Use lastUsedDirectory if available | ||
| if (!string.IsNullOrEmpty(instance.lastUsedDirectory)) | ||
| { | ||
| sfd.InitialDirectory = instance.lastUsedDirectory; |
There was a problem hiding this comment.
instead of calling this instance in here which I think might be a bit weird, have a getter which means we can, for static methods go FileIOManager.GetInstance().GetLastUsedDirectory(). This would make it consistent with the rest of the codebase too
| if (success) | ||
| { | ||
| // Update lastUsedDirectory | ||
| instance.lastUsedDirectory = Path.GetDirectoryName(sfd.FileName) ?? instance.lastUsedDirectory; |
| // Use lastUsedDirectory if available | ||
| if (!string.IsNullOrEmpty(instance.lastUsedDirectory)) | ||
| { | ||
| ofd.InitialDirectory = instance.lastUsedDirectory; |
| @@ -150,14 +168,28 @@ public static bool SaveConfigurationToFile(string path) | |||
| /// </summary> | |||
| public static void LoadConfigurationFromFile() | |||
| { | |||
| FileIOManager instance = GetInstance(); | |||
| ofd.Filter = "JSON (*.json)|*.json"; | ||
| if (ofd.ShowDialog() == DialogResult.OK) | ||
| { | ||
| string filePath = ofd.FileName; | ||
| using StreamReader sr = File.OpenText(filePath); | ||
| ConfigurationManager.GetInstance().PopulateServerConfiguration(sr.ReadToEnd()); | ||
|
|
||
| // Update lastUsedDirectory | ||
| instance.lastUsedDirectory = Path.GetDirectoryName(filePath) ?? instance.lastUsedDirectory; |
| /// Retrieves the application's version number. | ||
| /// </summary> | ||
| /// <returns>Formatted version string.</returns> | ||
| private string GetAppVersion() |
There was a problem hiding this comment.
This could also be used to populate the About Box if put in the FileIOManager singleton. Please look into doing that :)
| *.exe |
There was a problem hiding this comment.
.exe should already be in the gitignore
There was a problem hiding this comment.
I can't see it explicitly but the builds would be ignored here.
ArmaReforgerServerTool/.gitignore
Lines 16 to 26 in 472ea23
| // Retrieve the version from the assembly metadata using pattern matching | ||
| return Assembly.GetExecutingAssembly().GetName().Version switch | ||
| { | ||
| { } version => $"v{version.Major}.{version.Minor}.{version.Build}.{version.Revision}", | ||
| _ => "v0.0.0.0" // Fallback version if Version is null | ||
| }; |
There was a problem hiding this comment.
I'd prefer throwing on null version. It's the kind of thing that is either set or not, and it's vital for it to be set when released.
