Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove depricated ubuntu 18 from github actions CI #1006

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

joseph-v
Copy link
Collaborator

What this PR does / why we need it:
Remove depricated ubuntu 18 from github actions CI

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@joseph-v joseph-v force-pushed the fix_ci_ubuntu18 branch 2 times, most recently from 3cf10c2 to 9777cbd Compare June 12, 2023 15:25
@joseph-v joseph-v changed the title Remove depricated ubuntu 18 from github actions CI WIP: Remove depricated ubuntu 18 from github actions CI Jun 12, 2023
@joseph-v joseph-v force-pushed the fix_ci_ubuntu18 branch 5 times, most recently from f3fafff to d4d3919 Compare June 13, 2023 16:40
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #1006 (7b63bba) into master (f2765e1) will decrease coverage by 0.45%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
- Coverage   70.83%   70.38%   -0.45%     
==========================================
  Files         195      195              
  Lines       23987    24228     +241     
  Branches     3674     3338     -336     
==========================================
+ Hits        16991    17054      +63     
- Misses       5831     6015     +184     
+ Partials     1165     1159       -6     

see 84 files with indirect coverage changes

@joseph-v joseph-v changed the title WIP: Remove depricated ubuntu 18 from github actions CI Remove depricated ubuntu 18 from github actions CI Jun 13, 2023
Copy link
Collaborator

@sushanthakumar sushanthakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skdwriting skdwriting merged commit fe37664 into sodafoundation:master Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants