Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ssh excption error when the port is wrong and do some optimize #402

Merged
merged 20 commits into from
Dec 1, 2020

Conversation

jiangyutan
Copy link
Contributor

What this PR does / why we need it:
fix ssh excption error when the port is wrong and do some optimize

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #402 (b912a2c) into v0.8.0-maint (7be276d) will increase coverage by 0.03%.
The diff coverage is 70.00%.

@@               Coverage Diff                @@
##           v0.8.0-maint     #402      +/-   ##
================================================
+ Coverage         67.07%   67.10%   +0.03%     
================================================
  Files                93       93              
  Lines              6700     6688      -12     
  Branches            784      777       -7     
================================================
- Hits               4494     4488       -6     
+ Misses             1943     1942       -1     
+ Partials            263      258       -5     
Impacted Files Coverage Δ
delfin/drivers/utils/ssh_client.py 42.16% <0.00%> (ø)
delfin/drivers/ibm/storwize_svc/ssh_handler.py 73.51% <77.77%> (+1.06%) ⬆️

Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ThisIsClark ThisIsClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThisIsClark ThisIsClark merged commit 2bbaeb7 into sodafoundation:v0.8.0-maint Dec 1, 2020
kumarashit pushed a commit that referenced this pull request Jan 2, 2021
* Code improvement (#363)

* ibm storwize_svc add sshpool and fixed some issue (#381)

Add storage driver for IBM Storwize and svc series

* add hitachi vsp storage driver to community (#388)

Add hitachi vsp driver

* Fix vsp driver issue

* change pool status and some optimize for vsp (#395)

* rest api change timeout and fix trap parse (#401)

* fix ssh excption error when the port is wrong and do some optimize (#402)

* Update the value of 'update_at' of storage when going to sync the storage (#425)

* Code improvement (#363)

* ibm storwize_svc add sshpool and fixed some issue (#381)

Add storage driver for IBM Storwize and svc series

* add hitachi vsp storage driver to community (#388)

Add hitachi vsp driver

* Fix vsp driver issue

* change pool status and some optimize for vsp (#395)

* rest api change timeout and fix trap parse (#401)

* fix ssh excption error when the port is wrong and do some optimize (#402)

* Update the value of 'update_at' of storage when going to sync the storage (#425)

* Fix rebase issue

* Fixing CI failure issues

Co-authored-by: ThisIsClark <liuyuchibubao@gmail.com>
Co-authored-by: jiangyutan <69443713+jiangyutan@users.noreply.github.com>
Co-authored-by: Joseph Vazhappilly <josephvp@gmail.com>
Co-authored-by: root <pravin ranjan>
joseph-v pushed a commit that referenced this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants