Add Disk resource to Delfin #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-v
force-pushed
the
disk-resource
branch
2 times, most recently
from
7fa02e9
to
6a6cf4a
Compare
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
==========================================
+ Coverage 67.08% 67.52% +0.43%
==========================================
Files 99 101 +2
Lines 6800 6996 +196
Branches 762 780 +18
==========================================
+ Hits 4562 4724 +162
- Misses 2010 2035 +25
- Partials 228 237 +9
|
joseph-v
force-pushed
the
disk-resource
branch
7 times, most recently
from
2da166e
to
4ae161e
Compare
NajmudheenCT
reviewed
Dec 8, 2020
|
Same doubt with PR 403:
|
kumarashit
reviewed
Dec 17, 2020
| capacity = Column(BigInteger) | ||
| status = Column(String(255)) | ||
| physical_type = Column(String(255)) |
There was a problem hiding this comment.
Why the size of column always 255?AFAIK, Disk table may have a join with table with huge number of rows, this will have performance issue as per memory allocations.
Basically query processing will have side effects
There was a problem hiding this comment.
Raised an issue for this (#434) and will be handled separately.
joseph-v
dismissed stale reviews from ThisIsClark and NajmudheenCT
via
56e1be5
joseph-v
force-pushed
the
disk-resource
branch
3 times, most recently
from
56b8381
to
ce1d74f
Compare
joseph-v
force-pushed
the
disk-resource
branch
from
ce1d74f
to
55a5b43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add disk resource to Delfin resource model
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #404Special notes for your reviewer:
Release note: