Prometheus Alertmanager for delfin #429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 66.24% 66.26% +0.02%
==========================================
Files 95 95
Lines 6355 6356 +1
Branches 725 723 -2
==========================================
+ Hits 4210 4212 +2
+ Misses 1934 1933 -1
Partials 211 211
|
NajmudheenCT
requested changes
Dec 16, 2020
delfin/exporter/base_exporter.py
Outdated
| @@ -56,17 +53,23 @@ def __init__(self, namespace): | |||
| self.exporters = self._get_exporters() | |||
|
|
|||
| def dispatch(self, ctxt, data): | |||
| if not isinstance(data, (list, tuple)): | |||
There was a problem hiding this comment.
Hope this can't be removed. We need to pick the exporters form entry point
delfin/exporter/base_exporter.py
Outdated
| # err_msg = six.text_type(e) | ||
| # LOG.exception(err_msg) | ||
|
|
||
| prometheus_alert_obj = prometheus.PrometheusAlertExporter() |
There was a problem hiding this comment.
We need to handle exporteres dynamicllay by reading the entry point..
delfin/exporter/prometheus.py
Outdated
| @@ -13,6 +13,7 @@ | |||
| # limitations under the License. | |||
|
|
|||
|
|
|||
| import requests | |||
There was a problem hiding this comment.
Should we need this in requirements list ?
delfin/exporter/prometheus.py
Outdated
| dict["annotations"]["summary"] = data.get("description") | ||
|
|
||
| self.alerts.append(dict) | ||
| requests.post('http://localhost:9093/api/v1/alerts', json=self.alerts) |
There was a problem hiding this comment.
read alert manger host and port from config.
delfin/exporter/prometheus.py
Outdated
| 'location', 'recovery_advice', 'storage_id', 'storage_name', | ||
| 'vendor', 'model', 'serial_number'] | ||
|
|
||
| def push_prometheus_alert(self, data): |
There was a problem hiding this comment.
Add UTs for the new methods.
delfin/exporter/prometheus.py
Outdated
| @@ -73,8 +73,8 @@ class PrometheusAlertExporter(object): | |||
|
|
|||
| alerts = [] | |||
| model_key = ['alert_id', 'alert_name', 'category', 'severity', 'type', | |||
There was a problem hiding this comment.
Pls use all the model fields such as occur_time
delfin/exporter/prometheus.py
Outdated
| 'location', 'recovery_advice', 'storage_id', 'storage_name', | ||
| 'vendor', 'model', 'serial_number'] | ||
|
|
||
| def push_prometheus_alert(self, data): |
There was a problem hiding this comment.
data is expected to be a list of alerts to be exported
PravinRanjan10
force-pushed
the
master
branch
from
13960a8
to
e1f1934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It enables alerts to push prometheus alert manager
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: