Performance collection unregistration during storage deletion #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
==========================================
+ Coverage 67.90% 67.94% +0.04%
==========================================
Files 113 113
Lines 8185 8215 +30
Branches 919 926 +7
==========================================
+ Hits 5558 5582 +24
- Misses 2320 2321 +1
- Partials 307 312 +5
|
wisererik
approved these changes
Jan 5, 2021
|
Tested in a different environement . LGTM . A though for improvement is opend as an issue. #452 |
amanr032
pushed a commit
to amanr032/delfin
that referenced
this pull request
Dec 5, 2022
…ove reliability of service deployment. (sodafoundation#451) * Added the api, controller, dock and etcd processes to systemd. * Updated the clean up script. Renamed the etcd service. * Added missing line feed. Removed restart_policy from dock container. * Added the option of installing SODA services as standalone process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR addresses Performance collection unregistration during storage deletion
Currently 2 issues observed during storage deletion
This PR addresses these issues
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes ##440
Special notes for your reviewer:
One improvement is suggested on current performance collection.
To be tracked as part of below issue
#450
Detailed test report
Storage registration for performance collection:
Performance collection unregistration during storage delete
Restart after storage delete and no stale performance collection tasks:
Registration of multiple storages and unregistration of one storage:
Deletion of storage which is not registered for performance collection
Deletion of storage with some config file issue:
Release note: