Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dell_emc vplex device information collection #519

Merged
merged 6 commits into from
Mar 22, 2021

Conversation

tanjiangyu-ghca
Copy link
Contributor

@tanjiangyu-ghca tanjiangyu-ghca commented Mar 19, 2021

What this PR does / why we need it:
this PR is for dell_emc vplex storage,it provide dell_emc vplex storage's information collect,such as system,pools,volumes,alerts.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #519 (0b7d0f2) into master (411e041) will increase coverage by 0.14%.
The diff coverage is 74.43%.

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   70.26%   70.40%   +0.14%     
==========================================
  Files         127      131       +4     
  Lines        9860    10212     +352     
  Branches     1132     1165      +33     
==========================================
+ Hits         6928     7190     +262     
- Misses       2551     2628      +77     
- Partials      381      394      +13     
Impacted Files Coverage Δ
delfin/drivers/dell_emc/vplex/rest_handler.py 56.47% <56.47%> (ø)
delfin/drivers/dell_emc/vplex/vplex_stor.py 78.69% <78.69%> (ø)
delfin/drivers/dell_emc/vplex/alert_handler.py 88.23% <88.23%> (ø)
delfin/drivers/dell_emc/vplex/consts.py 100.00% <100.00%> (ø)

Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing setup.py changes . Update description of PR my modifying unity to vplex

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanjiangyu-ghca
Copy link
Contributor Author

Missing setup.py changes . Update description of PR my modifying unity to vplex

the update of setup.py submit in pr #516, it include unity,vnx,vplex setup information

@NajmudheenCT
Copy link
Member

Please update branch

Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit de4a577 into sodafoundation:master Mar 22, 2021
@liuxiaohuan-ghca liuxiaohuan-ghca deleted the emc_vplex branch March 29, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants