add trap desc mapping and change alert_lists sequence_number to match_key #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add trap desc mapping and change alert_lists sequence_number to match…
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
==========================================
+ Coverage 71.06% 71.08% +0.01%
==========================================
Files 137 138 +1
Lines 10622 10629 +7
Branches 1190 1191 +1
==========================================
+ Hits 7549 7556 +7
Misses 2692 2692
Partials 381 381
|
wisererik
reviewed
Apr 1, 2021
| @@ -119,13 +125,14 @@ def parse_queried_alerts(self, alert_model_list, alert_dict, query_para): | |||
| constants.Severity.INFORMATIONAL) | |||
| alert_model['category'] = constants.Category.FAULT | |||
| alert_model['type'] = constants.EventType.EQUIPMENT_ALARM | |||
| alert_model['sequence_number'] = content.get('id') | |||
There was a problem hiding this comment.
please keep sequense_number here
Merge pull request #58 from tanjiangyu-ghca/unity0401
add trap desc mapping and add match_key to unity alert
add trap desc mapping and add match_key to unity alert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
1.add trap desc mapping;
2. change alert_lists sequence_number to match_ke.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: