Emc vnx block:Modifying exception types #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
=======================================
Coverage 71.08% 71.08%
=======================================
Files 138 138
Lines 10629 10629
Branches 1191 1191
=======================================
Hits 7556 7556
Misses 2692 2692
Partials 381 381
|
kumarashit
reviewed
Apr 2, 2021
| @@ -24,8 +24,8 @@ | |||
| EXCEPTION_MAP = {CER_ERR: exception.SSLCertificateFailed, | |||
| CALLER_ERR: exception.InvalidUsernameOrPassword, | |||
| SECURITY_ERR: exception.InvalidUsernameOrPassword, | |||
| TRYING_CONNECT_ERR: exception.ConnectTimeout, | |||
| CONNECTION_ERR: exception.ConnectTimeout, | |||
| TRYING_CONNECT_ERR: exception.InvalidIpOrPort, | |||
There was a problem hiding this comment.
What is there is some network connectivity issue? It may not be invalid IP or PORT
There was a problem hiding this comment.
Page display requirements
There was a problem hiding this comment.
Ok hope the message is displayed accordingly
jiangyutan
force-pushed
the
emc_vnx_block_0402
branch
from
3e0da98
to
d1b4454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Modifying exception types
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Modifying exception types
Special notes for your reviewer:
Release note: