Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github actions to delfin #552

Merged
merged 3 commits into from
May 20, 2021

Conversation

joseph-v
Copy link
Collaborator

@joseph-v joseph-v commented Apr 12, 2021

What this PR does / why we need it:
Add Github actions to delfin

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #554

Special notes for your reviewer:
Github actions running of the fork: https://github.com/joseph-v/delfin/actions/runs/806330240

Release note:

Screenshot from 2021-04-12 12-35-42

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #552 (3dbf2e7) into master (7ec6784) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 3dbf2e7 differs from pull request most recent head 2fa5eab. Consider uploading reports for the commit 2fa5eab to get more accurate results

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   71.16%   71.08%   -0.08%     
==========================================
  Files         138      138              
  Lines       10524    10629     +105     
  Branches     1172     1191      +19     
==========================================
+ Hits         7489     7556      +67     
- Misses       2661     2692      +31     
- Partials      374      381       +7     
Impacted Files Coverage Δ
...in/drivers/dell_emc/vnx/vnx_block/alert_handler.py 81.25% <0.00%> (-15.53%) ⬇️
...n/drivers/dell_emc/vnx/vnx_block/navicli_client.py 30.43% <0.00%> (-10.75%) ⬇️
delfin/drivers/hpe/hpe_3par/component_handler.py 73.91% <0.00%> (-4.19%) ⬇️
delfin/drivers/dell_emc/vnx/vnx_block/vnx_block.py 75.55% <0.00%> (-3.99%) ⬇️
...fin/drivers/dell_emc/vnx/vnx_block/navi_handler.py 73.08% <0.00%> (-1.06%) ⬇️
delfin/utils.py 28.57% <0.00%> (-0.47%) ⬇️
delfin/exception.py 98.81% <0.00%> (-0.02%) ⬇️
delfin/drivers/utils/rest_client.py 41.79% <0.00%> (ø)
delfin/alert_manager/snmp_validator.py 78.12% <0.00%> (ø)
delfin/drivers/hpe/hpe_3par/rest_handler.py 34.54% <0.00%> (ø)
... and 3 more

@joseph-v joseph-v force-pushed the github_action_ci branch 3 times, most recently from 1183702 to 9f9b92e Compare April 12, 2021 09:54
@joseph-v joseph-v changed the title [WIP] Add Github actions to delfin Add Github actions to delfin Apr 27, 2021
@joseph-v joseph-v force-pushed the github_action_ci branch 2 times, most recently from 2f97d52 to 98f6f4d Compare May 3, 2021 09:15
@@ -1,16 +0,0 @@
language: python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us remove travis.yml after the organisation settings are updated. Otherwise it may impact any PRS coming in between

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already removed

Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kumarashit
kumarashit previously approved these changes May 7, 2021
Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Actions run is success on local branch

NajmudheenCT
NajmudheenCT previously approved these changes May 12, 2021
Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NajmudheenCT
Copy link
Member

@skdwriting please merge this

Copy link
Collaborator

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skdwriting
Copy link
Collaborator

CI migration in progress to github actions, local ci ok. hence merging.

@skdwriting skdwriting merged commit 107c99b into sodafoundation:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change delfin CI from Travis to Github actions
5 participants