Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emc vplex add controller port interface #572

Merged
merged 23 commits into from
Jun 4, 2021

Conversation

liuxiaohuan-ghca
Copy link
Contributor

@liuxiaohuan-ghca liuxiaohuan-ghca commented May 19, 2021

What this PR does / why we need it:
1 add vplex controller port interface
2 update vplex port default value setting method

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #572 (d243f4e) into master (782bc59) will increase coverage by 0.07%.
The diff coverage is 76.37%.

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
+ Coverage   72.06%   72.13%   +0.07%     
==========================================
  Files         141      141              
  Lines       12036    12211     +175     
  Branches     1413     1446      +33     
==========================================
+ Hits         8674     8809     +135     
- Misses       2887     2909      +22     
- Partials      475      493      +18     
Impacted Files Coverage Δ
delfin/drivers/dell_emc/vplex/rest_handler.py 50.48% <21.05%> (-5.99%) ⬇️
delfin/drivers/dell_emc/vplex/vplex_stor.py 80.77% <81.93%> (+1.46%) ⬆️
delfin/drivers/dell_emc/vplex/alert_handler.py 87.50% <100.00%> (-0.74%) ⬇️
delfin/drivers/dell_emc/vplex/consts.py 100.00% <100.00%> (ø)

NajmudheenCT
NajmudheenCT previously approved these changes Jun 1, 2021
Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThisIsClark
Copy link
Collaborator

Please make a more meaningful title for this PR

@liuxiaohuan-ghca liuxiaohuan-ghca changed the title Emc vplex 0517 Emc vplex add controller port interface Jun 4, 2021
Copy link
Collaborator

@ThisIsClark ThisIsClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit 73fe3a1 into sodafoundation:master Jun 4, 2021
@liuxiaohuan-ghca liuxiaohuan-ghca deleted the emc_vplex_0517 branch July 28, 2021 08:00
joseph-v pushed a commit that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants