emc unity add controller disk port filesystem share qtree quota fouction #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emc unity add controller disk port filesystem share qtree quota fouction
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
- Coverage 72.04% 71.94% -0.10%
==========================================
Files 141 141
Lines 11618 11905 +287
Branches 1352 1392 +40
==========================================
+ Hits 8370 8565 +195
- Misses 2807 2874 +67
- Partials 441 466 +25
|
emc unity add controller disk port filesystem share qtree quota fouction
joseph-v
reviewed
May 31, 2021
| pool_entries = controller_info.get('entries') | ||
| for pool in pool_entries: | ||
| content = pool.get('content', {}) | ||
| health_value = content.get('health').get('value') |
There was a problem hiding this comment.
This can generate exception if content is {}
Suggested change
| health_value = content.get('health').get('value') | |
| health_value = content.get('health', {}).get('value') |
| port_entries = ports.get('entries') | ||
| for port in port_entries: | ||
| content = port.get('content', {}) | ||
| health_value = content.get('health').get('value') |
| for ip_info in ip_interfaces.get('entries'): | ||
| ip_content = ip_info.get('content', {}) | ||
| if content.get('id') == ip_content.get( | ||
| 'ipPort').get('id'): |
| port_entries = ports.get('entries') | ||
| for port in port_entries: | ||
| content = port.get('content', {}) | ||
| health_value = content.get('health').get('value') |
| disk_entries = disks.get('entries') | ||
| for disk in disk_entries: | ||
| content = disk.get('content', {}) | ||
| health_value = content.get('health').get('value') |
There was a problem hiding this comment.
Same issue in many places
emc unity add controller disk port filesystem share qtree quota fouction
delete codecoverage more than 70%
use resourse's own status
wisererik
requested changes
Jun 4, 2021
change code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
emc unity add controller disk port filesystem share qtree quota fouctions
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: