DB models and API changes for host mapping #606

sushanthakumar · 2021-06-14T02:28:37Z

What this PR does / why we need it:
This PR adds DB APIs and models for host mapping models

Feature Design doc for reference:
RequirementsDesignSpec_HostMapping.docx

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
UT scripts to be added to this PR
Currently fake values are random values without any relation just to verify db operations

Test report
DB Tables

DB Table Entries

Release note:

codecov · 2021-06-14T02:30:28Z

Codecov Report

Merging #606 (80b2563) into host_mapping (73fe3a1) will decrease coverage by 2.73%.
The diff coverage is 33.56%.

@@               Coverage Diff                @@
##           host_mapping     #606      +/-   ##
================================================
- Coverage         72.13%   69.40%   -2.74%     
================================================
  Files               141      144       +3     
  Lines             12211    13795    +1584     
  Branches           1446     1653     +207     
================================================
+ Hits               8809     9575     +766     
- Misses             2909     3688     +779     
- Partials            493      532      +39

Impacted Files	Coverage Δ
delfin/db/sqlalchemy/api.py	`59.39% <17.54%> (-20.63%)`	⬇️
delfin/db/api.py	`79.68% <50.00%> (-15.13%)`	⬇️
delfin/db/sqlalchemy/models.py	`99.66% <100.00%> (+0.12%)`	⬆️
delfin/exception.py	`98.94% <100.00%> (+0.11%)`	⬆️
delfin/coordination.py	`63.93% <0.00%> (-23.08%)`	⬇️
...er/scheduler/schedulers/telemetry/telemetry_job.py	`77.27% <0.00%> (-15.04%)`	⬇️
...duler/schedulers/telemetry/failed_telemetry_job.py	`79.74% <0.00%> (-11.03%)`	⬇️
delfin/exporter/prometheus/prometheus.py	`26.38% <0.00%> (-5.62%)`	⬇️
delfin/drivers/dell_emc/unity/unity.py	`71.42% <0.00%> (-5.20%)`	⬇️
delfin/task_manager/scheduler/schedule_manager.py	`55.55% <0.00%> (-4.45%)`	⬇️
... and 28 more

sushanthakumar · 2021-06-14T15:07:26Z

@NajmudheenCT @wisererik @kumarashit @joseph-v @AmitRoushan , pls help to review

joseph-v · 2021-06-15T03:29:19Z

delfin/db/api.py

@@ -841,3 +841,491 @@ def failed_task_delete_by_storage(context, storage_id):
    does not exist.
    """
    return IMPL.failed_task_delete_by_storage(context, storage_id)
+
+
+def storage_initiators_create(context, values):


Can we use just initiators instead of storage_initiators ?

joseph-v · 2021-06-15T03:30:13Z

delfin/db/api.py

+    return IMPL.storage_hosts_delete(context, values)
+
+
+def storage_hosts_get(context, storage_host_id):


storage_hosts -> hosts ?

This need not change

NajmudheenCT · 2021-06-18T05:13:14Z

delfin/db/sqlalchemy/models.py

+    name = Column(String(255))
+    description = Column(String(255))
+    os_type = Column(String(255))
+    storage_host_initiators = Column(Text)


This may not require as we keep host relation in initiator

sushanthakumar · 2021-06-18T15:16:39Z

Pls help to review @wisererik @kumarashit @joseph-v @AmitRoushan @ThisIsClark

delfin/db/sqlalchemy/api.py

ThisIsClark · 2021-06-22T06:32:07Z

delfin/exception.py

@@ -170,6 +170,42 @@ class VolumeNotFound(NotFound):
    msg_fmt = _("Volume {0} could not be found.")


+class StorageHostInitiatorNotFound(NotFound):
+    msg_fmt = _("Storage host initiator{0} could not be found.")


initiator{0} should be initiator {0}

sushanthakumar · 2021-06-23T03:24:29Z

Updated for the comments
@NajmudheenCT @kumarashit @wisererik @ThisIsClark @AmitRoushan pls check and approve

ThisIsClark · 2021-06-22T06:35:07Z

delfin/exception.py

+
+
+class VolumeGroupNotFound(NotFound):
+    msg_fmt = _("Port group {0} could not be found.")


msg_fmt is same as PortGroupNotFound

ThisIsClark

LGTM

NajmudheenCT · 2021-06-24T14:25:54Z

delfin/db/api.py

+                                                    host_grp_host_relation_id)
+
+
+def storage_host_grp_host_relations_get_all(context, marker=None, limit=None,


lets use table name as suffix for all operations storage_host_grp_host_rels_get_all ? applicable for all group relation related APS

NajmudheenCT

LGTM

wisererik · 2021-06-25T07:49:50Z

delfin/db/sqlalchemy/models.py

+    native_storage_host_id = Column(String(255))
+    storage_host_initiators = Column(Text)
+    volumes = Column(Text)
+    ports = Column(Text)


confused about the below defintion, can you explain it

storage_host_initiators = Column(Text) volumes = Column(Text) ports = Column(Text)

Provided some details on this at driver api side.

NajmudheenCT

LGTM

sushanthakumar added 2 commits June 13, 2021 22:38

db models for host mapping

e003ac5

DB API changes

c7a6bdb

sushanthakumar changed the base branch from master to host_mapping June 14, 2021 02:28

sushanthakumar mentioned this pull request Jun 14, 2021

Host mapping management : Feature implementation and validation #568

Closed

6 tasks

sushanthakumar changed the title ~~[WIP] DB API changes for host mapping~~ DB API changes for host mapping Jun 14, 2021

joseph-v reviewed Jun 15, 2021

View reviewed changes

Updated attribute names and api names

4287ba7

NajmudheenCT reviewed Jun 18, 2021

View reviewed changes

sushanthakumar force-pushed the hostmapping-db-apis branch from e848aeb to ee96751 Compare June 18, 2021 15:32

Removed initiator list from host

cdf299b

sushanthakumar force-pushed the hostmapping-db-apis branch from ee96751 to cdf299b Compare June 19, 2021 03:37

sushanthakumar mentioned this pull request Jun 19, 2021

DB models for host mapping #596

Closed

sushanthakumar changed the title ~~DB API changes for host mapping~~ DB models and API changes for host mapping Jun 19, 2021

kumarashit reviewed Jun 21, 2021

View reviewed changes

delfin/db/sqlalchemy/api.py Show resolved Hide resolved

ThisIsClark reviewed Jun 22, 2021

View reviewed changes

sushanthakumar force-pushed the hostmapping-db-apis branch from a0f7e35 to 8551547 Compare June 24, 2021 06:22

ThisIsClark reviewed Jun 24, 2021

View reviewed changes

sushanthakumar force-pushed the hostmapping-db-apis branch from 8551547 to e9b570d Compare June 24, 2021 08:06

ThisIsClark approved these changes Jun 24, 2021

View reviewed changes

NajmudheenCT reviewed Jun 24, 2021

View reviewed changes

Review comment update

f63c741

sushanthakumar force-pushed the hostmapping-db-apis branch from e9b570d to f63c741 Compare June 24, 2021 17:10

NajmudheenCT approved these changes Jun 25, 2021

View reviewed changes

wisererik reviewed Jun 25, 2021

View reviewed changes

Updated for masking view model change

80b2563

sushanthakumar force-pushed the hostmapping-db-apis branch from d428879 to 80b2563 Compare June 26, 2021 08:12

NajmudheenCT approved these changes Jun 26, 2021

View reviewed changes

wisererik merged commit ef852eb into sodafoundation:host_mapping Jun 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DB models and API changes for host mapping #606

DB models and API changes for host mapping #606

sushanthakumar commented Jun 14, 2021 •

edited

Loading

codecov bot commented Jun 14, 2021 •

edited

Loading

sushanthakumar commented Jun 14, 2021

joseph-v Jun 15, 2021

sushanthakumar Jun 15, 2021

joseph-v Jun 15, 2021

sushanthakumar Jun 15, 2021

NajmudheenCT Jun 18, 2021

sushanthakumar Jun 18, 2021

sushanthakumar commented Jun 18, 2021

ThisIsClark Jun 22, 2021

sushanthakumar Jun 22, 2021

sushanthakumar commented Jun 23, 2021 •

edited

Loading

ThisIsClark Jun 22, 2021

sushanthakumar Jun 24, 2021

ThisIsClark left a comment

NajmudheenCT Jun 24, 2021

sushanthakumar Jun 24, 2021

NajmudheenCT left a comment

wisererik Jun 25, 2021

sushanthakumar Jun 25, 2021 •

edited

Loading

NajmudheenCT left a comment

		return IMPL.storage_hosts_delete(context, values)


		def storage_hosts_get(context, storage_host_id):



		class VolumeGroupNotFound(NotFound):
		msg_fmt = _("Port group {0} could not be found.")

		host_grp_host_relation_id)


		def storage_host_grp_host_relations_get_all(context, marker=None, limit=None,

DB models and API changes for host mapping #606

DB models and API changes for host mapping #606

Conversation

sushanthakumar commented Jun 14, 2021 • edited Loading

codecov bot commented Jun 14, 2021 • edited Loading

Codecov Report

sushanthakumar commented Jun 14, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sushanthakumar commented Jun 18, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sushanthakumar commented Jun 23, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ThisIsClark left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NajmudheenCT left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sushanthakumar Jun 25, 2021 • edited Loading

Choose a reason for hiding this comment

NajmudheenCT left a comment

Choose a reason for hiding this comment

sushanthakumar commented Jun 14, 2021 •

edited

Loading

codecov bot commented Jun 14, 2021 •

edited

Loading

sushanthakumar commented Jun 23, 2021 •

edited

Loading

sushanthakumar Jun 25, 2021 •

edited

Loading