Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hitachi vsp controller disk port resources #612

Merged
merged 6 commits into from
Jun 29, 2021

Conversation

guankc
Copy link
Contributor

@guankc guankc commented Jun 18, 2021

What this PR does / why we need it:
add hitachi vsp controller disk port resources

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #612 (1bfec2f) into master (b3de5b4) will decrease coverage by 0.03%.
The diff coverage is 61.17%.

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   70.28%   70.24%   -0.04%     
==========================================
  Files         156      156              
  Lines       14232    14314      +82     
  Branches     1689     1701      +12     
==========================================
+ Hits        10003    10055      +52     
- Misses       3688     3711      +23     
- Partials      541      548       +7     
Impacted Files Coverage Δ
delfin/drivers/hitachi/vsp/rest_handler.py 42.52% <25.00%> (-1.78%) ⬇️
delfin/drivers/hitachi/vsp/vsp_stor.py 70.49% <69.56%> (+0.75%) ⬆️

Copy link
Collaborator

@ThisIsClark ThisIsClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NajmudheenCT NajmudheenCT merged commit 4d4d6c6 into sodafoundation:master Jun 29, 2021
@tanjiangyu-ghca tanjiangyu-ghca deleted the vsp6191 branch December 10, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants