Use consistent resource name and serial number for fake driver across different collections #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
==========================================
- Coverage 71.88% 71.86% -0.02%
==========================================
Files 141 141
Lines 12562 12570 +8
Branches 1499 1501 +2
==========================================
+ Hits 9030 9034 +4
- Misses 3017 3021 +4
Partials 515 515
|
| "storage_id": self.storage_id, | ||
| "native_storage_pool_id": "fake_original_id_" + str(idx), | ||
| "native_storage_pool_id": "storagePool_" + str(idx), |
There was a problem hiding this comment.
Convention looks fine, how about using "native_" prefix for native ids just to differentiate it from name
There was a problem hiding this comment.
IMO which will be again confusing.. because in metric we keep resource_id as a common label for all resources.. It is supposed to be the native_id .. in order to avoid confusion lets keep resource name and native_id same..
joseph-v
reviewed
Jun 21, 2021
Co-authored-by: Joseph Vazhappilly <josephvp@gmail.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use similar naming pattern for resource names in resource and perf metric collection
Fix for #619
increased E2E tests sleep time to 5sec to give some time for the DB to get updated before the next test run
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #619Special notes for your reviewer:
This is to help delfin clients to test with fake driver
Release note: