Build resource group and resource relations #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delfin/db/sqlalchemy/api.py
Outdated
| @@ -2490,7 +2490,7 @@ def masking_views_delete_by_storage(context, storage_id): | |||
|
|
|||
|
|
|||
| def _storage_host_grp_host_rels_get_query(context, session=None): | |||
| return model_query(context, models.StorageHostGrpHostRel, | |||
| return model_query(context, models.StorageHostGroupRelation, | |||
There was a problem hiding this comment.
U can refer table names from existing models and update the usages accordingly
joseph-v
force-pushed
the
hostmapping-relations
branch
from
3977271
to
c5a52f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
==========================================
+ Coverage 70.15% 70.83% +0.68%
==========================================
Files 156 156
Lines 14801 14913 +112
Branches 1822 1855 +33
==========================================
+ Hits 10384 10564 +180
+ Misses 3816 3743 -73
- Partials 601 606 +5
|
| @@ -741,6 +815,12 @@ def sync(self): | |||
| # Build relation between host grp and host to be handled here. | |||
| storage_host_groups = self.driver_api \ | |||
| .list_storage_host_groups(self.context, self.storage_id) | |||
| if storage_host_groups: | |||
There was a problem hiding this comment.
Whenever we build group relations for any sync cycle, old relations to be flushed first.
There was a problem hiding this comment.
Already doing it, line no: 89,115,136
There was a problem hiding this comment.
yes, fine, missed it
delfin/db/sqlalchemy/models.py
Outdated
| @@ -366,7 +366,7 @@ class StorageHostGrpHostRel(BASE, DelfinBase): | |||
| """Represents the storage host group and storage host relation | |||
| attributes. | |||
| """ | |||
| __tablename__ = 'storage_host_grp_host_rels' | |||
| __tablename__ = 'storage_host_group_relations' | |||
There was a problem hiding this comment.
Currently tablename is in sync with class name, I think we can follow same convention here as well
joseph-v
force-pushed
the
hostmapping-relations
branch
from
c5a52f1
to
2deeaec
Compare
joseph-v
changed the title
NajmudheenCT
requested changes
Aug 24, 2021
|
LGTM |
joseph-v
force-pushed
the
hostmapping-relations
branch
4 times, most recently
from
9d5e0ee
to
53aad5f
Compare
joseph-v
force-pushed
the
hostmapping-relations
branch
from
53aad5f
to
5ab57f6
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Build resource group and resource relations for resources of storage host, port and volume.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: