Add storage status:degraded #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #769 +/- ##
==========================================
+ Coverage 70.32% 70.33% +0.01%
==========================================
Files 163 163
Lines 15875 15876 +1
Branches 1967 1967
==========================================
+ Hits 11164 11167 +3
Misses 4034 4034
+ Partials 677 675 -2
|
ThisIsClark
reviewed
Nov 12, 2021
|
|
||
| ALL = (NORMAL, OFFLINE, ABNORMAL) | ||
| ALL = (NORMAL, OFFLINE, ABNORMAL, DEGRADED) |
There was a problem hiding this comment.
After adding this, where would use it? Would it be in another PR?
There was a problem hiding this comment.
Storage devices, such as netapp and 3par and hnas storage devices, have the status value degraded. This enumeration can be added to more accurately describe the device status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add storage status:degraded
Which issue this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note: