Add VMAX disk resource support #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #776 +/- ##
==========================================
- Coverage 70.20% 70.20% -0.01%
==========================================
Files 163 163
Lines 15910 15934 +24
Branches 2272 2275 +3
==========================================
+ Hits 11170 11186 +16
- Misses 4063 4071 +8
Partials 677 677
|
joseph-v
force-pushed
the
vmax_disk_resource
branch
from
483a368
to
8a1cab1
Compare
joseph-v
changed the title
NajmudheenCT
reviewed
Dec 3, 2021
| self.array_id, self.uni_version, disk) | ||
|
|
||
| disk_item = { | ||
| 'name': 'disk_' + disk, |
There was a problem hiding this comment.
Do we need to prefix 'disk_' , if we do so it will be different from the element manager showed disk name!
wisererik
reviewed
Dec 13, 2021
joseph-v
force-pushed
the
vmax_disk_resource
branch
from
57230b3
to
419dbf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: