Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsp add alerts get #787

Merged
merged 6 commits into from
Jan 5, 2022
Merged

vsp add alerts get #787

merged 6 commits into from
Jan 5, 2022

Conversation

tanjiangyu-ghca
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #787 (42041db) into master (92919b8) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
- Coverage   70.58%   70.56%   -0.03%     
==========================================
  Files         174      174              
  Lines       17969    17978       +9     
  Branches     2639     2640       +1     
==========================================
+ Hits        12684    12686       +2     
- Misses       4500     4504       +4     
- Partials      785      788       +3     
Impacted Files Coverage Δ
delfin/drivers/hitachi/vsp/rest_handler.py 42.13% <25.00%> (-0.40%) ⬇️
delfin/drivers/hitachi/vsp/vsp_stor.py 70.30% <37.50%> (-0.20%) ⬇️
delfin/drivers/fake_storage/__init__.py 94.79% <0.00%> (-0.55%) ⬇️

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v joseph-v merged commit 8332cd7 into sodafoundation:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants