Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pure #791

Merged
merged 90 commits into from
Jan 7, 2022
Merged

add pure #791

merged 90 commits into from
Jan 7, 2022

Conversation

zhilong-xu
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

zhilong-xu and others added 30 commits October 14, 2021 16:13
# Conflicts:
#	delfin/drivers/pure/storage/rest_handler.py
#	delfin/drivers/pure/storage/storage.py
#	delfin/tests/unit/drivers/pure/storage/test_storage.py
pure codeview 代码简洁优化
Suggestions for improving Huawei: Simplify and optimize all function names and codes of Pure
pure codeview-recompose test_reset_connection
pure codeview-Delete unnecessary Definitions
pure codeview-Modified the function name
pure codeview-Add files and change class names
pure codeview-Remove unnecessary function wrapping
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #791 (09be3da) into master (6777776) will increase coverage by 0.06%.
The diff coverage is 74.03%.

@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
+ Coverage   70.51%   70.58%   +0.06%     
==========================================
  Files         177      180       +3     
  Lines       18279    18641     +362     
  Branches     2695     2749      +54     
==========================================
+ Hits        12889    13157     +268     
- Misses       4572     4643      +71     
- Partials      818      841      +23     
Impacted Files Coverage Δ
delfin/drivers/pure/flasharray/rest_handler.py 33.78% <33.78%> (ø)
delfin/drivers/pure/flasharray/pure_flasharray.py 82.62% <82.62%> (ø)
delfin/drivers/pure/flasharray/consts.py 100.00% <100.00%> (ø)

@@ -0,0 +1,351 @@
import datetime
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add file banner for Copyright in all new files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have already added

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit 8c7b697 into sodafoundation:master Jan 7, 2022
@zhilong-xu zhilong-xu deleted the pure_2022 branch January 27, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants