Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unity add host mapping view #795

Merged
merged 22 commits into from
May 20, 2022
Merged

Conversation

tanjiangyu-ghca
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #795 (2ba5f98) into master (c9c842c) will decrease coverage by 0.01%.
The diff coverage is 64.42%.

@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
- Coverage   71.34%   71.33%   -0.02%     
==========================================
  Files         182      182              
  Lines       21133    21237     +104     
  Branches     3226     3243      +17     
==========================================
+ Hits        15077    15149      +72     
- Misses       5037     5063      +26     
- Partials     1019     1025       +6     
Impacted Files Coverage Δ
delfin/drivers/dell_emc/unity/rest_handler.py 44.66% <25.00%> (-1.66%) ⬇️
delfin/drivers/dell_emc/unity/unity.py 68.08% <71.59%> (+0.52%) ⬆️
delfin/drivers/fake_storage/__init__.py 95.16% <0.00%> (+1.27%) ⬆️

joseph-v
joseph-v previously approved these changes Jan 21, 2022
Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit 7953bc8 into sodafoundation:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants