Hpe 3par add host mapping view #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #798 +/- ##
==========================================
+ Coverage 70.57% 70.80% +0.23%
==========================================
Files 181 181
Lines 19324 19547 +223
Branches 2868 2921 +53
==========================================
+ Hits 13637 13840 +203
- Misses 4793 4795 +2
- Partials 894 912 +18
|
yuanyu-ghca
force-pushed
the
hpe_3par_hostmap
branch
from
2f6b555 to
a28df8f
Compare
yuanyu-ghca
force-pushed
the
hpe_3par_hostmap
branch
2 times, most recently
from
a173acf to
e4b0270
Compare
3par add host mapping view
3par add host mapping view
3par add host mapping view
joseph-v
reviewed
Jan 21, 2022
| 'native_port_group_id': native_port_group_id, | ||
| "storage_id": storage_id | ||
| } | ||
| if 'set:' in vv_name: |
There was a problem hiding this comment.
We need to validate mandatory fields are set in masking view.
From file <>/delfin/drivers/driver.py, function list_masking_views() comments, mandatory fields:
From host side: Mandatorily one of the (native_storage_host_group_id | native_storage_host_id)
From volume side: Mandatorily one of the (native_volume_group_id | native_volume_id)
From port side: Optionally (native_port_group_id)
JiuyunZhao
reviewed
Jan 21, 2022
| host_name = view.get('hostname') | ||
| if vv_name and host_name: | ||
| port = view.get('port', '').replace('-', '') | ||
| id = view.get('lun') |
There was a problem hiding this comment.
id is a built-in name, please use another name instead.
modify test unit
Optimize disk status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
1 add host mapping view
Which issue this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note: