Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change svc fc port id #800

Merged
merged 3 commits into from
Jan 21, 2022
Merged

change svc fc port id #800

merged 3 commits into from
Jan 21, 2022

Conversation

tanjiangyu-ghca
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #800 (4306ee5) into master (8cf0d7e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
- Coverage   70.57%   70.55%   -0.02%     
==========================================
  Files         180      180              
  Lines       18646    18646              
  Branches     2750     2750              
==========================================
- Hits        13159    13156       -3     
- Misses       4645     4646       +1     
- Partials      842      844       +2     
Impacted Files Coverage Δ
delfin/drivers/ibm/storwize_svc/ssh_handler.py 72.89% <100.00%> (ø)
delfin/drivers/fake_storage/__init__.py 93.63% <0.00%> (-0.77%) ⬇️

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v joseph-v merged commit 60914f9 into sodafoundation:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants