Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsp change disk status #808

Merged
merged 11 commits into from
Feb 10, 2022
Merged

vsp change disk status #808

merged 11 commits into from
Feb 10, 2022

Conversation

tanjiangyu-ghca
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #808 (cda26bd) into master (928641a) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master     #808   +/-   ##
=======================================
  Coverage   70.57%   70.58%           
=======================================
  Files         180      180           
  Lines       18650    18652    +2     
  Branches     2750     2750           
=======================================
+ Hits        13163    13166    +3     
  Misses       4645     4645           
+ Partials      842      841    -1     
Impacted Files Coverage Δ
delfin/drivers/hitachi/vsp/vsp_stor.py 70.52% <66.66%> (+0.22%) ⬆️
delfin/drivers/fake_storage/__init__.py 94.65% <0.00%> (+0.25%) ⬆️

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v joseph-v merged commit ce1080e into sodafoundation:master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants