Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an enumerated value "degraded" for disk status. #829

Merged

Conversation

JiuyunZhao
Copy link
Contributor

What this PR does / why we need it:
There is a "Degraded" status of disk in HPE 3PAR, I think we should add it as an enumerated value of disk status.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #829 (46f11c2) into master (cf6bb3b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #829      +/-   ##
==========================================
- Coverage   70.58%   70.56%   -0.02%     
==========================================
  Files         180      180              
  Lines       18653    18654       +1     
  Branches     2750     2750              
==========================================
- Hits        13166    13164       -2     
- Misses       4645     4646       +1     
- Partials      842      844       +2     
Impacted Files Coverage Δ
delfin/common/constants.py 100.00% <100.00%> (ø)
delfin/drivers/fake_storage/__init__.py 93.63% <0.00%> (-0.77%) ⬇️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sushanthakumar
Copy link
Collaborator

LGTM

@wisererik wisererik merged commit 0f352bb into sodafoundation:master Feb 21, 2022
@JiuyunZhao JiuyunZhao deleted the jiuyunzhao_disk_status_20220415 branch June 8, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants