-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Centralized Manager support #850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #850 +/- ##
==========================================
- Coverage 71.35% 71.26% -0.09%
==========================================
Files 182 182
Lines 21240 21326 +86
Branches 3241 3263 +22
==========================================
+ Hits 15156 15199 +43
- Misses 5059 5095 +36
- Partials 1025 1032 +7
|
joseph-v
changed the title
WIP: Add Centralized Manager support
Add Centralized Manager support
May 17, 2022
wisererik
approved these changes
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
skdwriting
approved these changes
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add Centralized Manager support
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #549Special notes for your reviewer:
Link to Design document: sodafoundation/architecture-analysis#120
This feature is verified using VMAX simulator.
Following is the steps to run VMAX Simulator in an Ubuntu 18.04 machine.
This will start a VMAX simulator on the http://localhost:8443
To Test Centralized Manager feature with VMAX Simulator:
To Test Centralized Manager feature with Embedded array using fake driver:
To Test SNMP Alert using VMAX Simulator:
trap_receiver_port = 8162
to delfin.conf, under [DEFAULT]python snmptest.py 000196700153
)Release note:
This feature is verified only with VMAX simulator and fake driver, and not verified in Hardware